fix(huggingface): Capture streamed tool calls#1848
Open
Luca Forstner (lforst) wants to merge 3 commits intomainfrom
Open
fix(huggingface): Capture streamed tool calls#1848Luca Forstner (lforst) wants to merge 3 commits intomainfrom
Luca Forstner (lforst) wants to merge 3 commits intomainfrom
Conversation
Luca Forstner (lforst)
requested review from
Abhijeet Prasad (AbhiPrasad) and
Stephen Belanger (Qard)
Stephen Belanger (Qard)
approved these changes
Apr 20, 2026
Contributor
Stephen Belanger (Qard)
left a comment
Stephen Belanger (Qard)
left a comment
There was a problem hiding this comment.
Generally LGTM, though we might want to consider avoiding this field merging pattern as we're adding unnecessary overhead with that and it's difficult to read anyway.
Comment on lines
+540
to
+543
| ...(typeof deltaFunction.name === "string" && | ||
| typeof currentFunction.name !== "string" | ||
| ? { name: deltaFunction.name } | ||
| : {}), |
Contributor
There was a problem hiding this comment.
This pattern of constructing an object only to immediately destructure it and merge it into another is a bit wasteful and not particularly readable. Seems to be used a bunch in this PR. We should probably just build that into a separate name variable directly without all that destructuring complication.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were ignoring streamed tool calls.
Fixes #1846