feat: Add experiment dataset filter to experiment metadata#1898
Merged
max-braintrust merged 11 commits intomainfrom Apr 24, 2026
Merged
feat: Add experiment dataset filter to experiment metadata#1898max-braintrust merged 11 commits intomainfrom
max-braintrust merged 11 commits intomainfrom
Conversation
Abhijeet Prasad (AbhiPrasad)
approved these changes
Apr 23, 2026
Luca Forstner (lforst)
approved these changes
Apr 24, 2026
Member
Luca Forstner (lforst)
left a comment
There was a problem hiding this comment.
It would be great if you could still add to the PR description how a user would use this or how this is used in the product!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stores _internal_btql filters for experiment datasets in the experiment metadata.
Right now we don’t persist those filter options, so we lose the ability to reconstruct the exact subset of rows an experiment ran against. If we save them with the experiment, we can recreate the same row set later instead of having to guess.
This unlocks a few useful things: