watch bt releases on npm, update local bt version on update#2067
Closed
Cedric / ViaDézo1er (viadezo1er) wants to merge 1 commit into
Closed
watch bt releases on npm, update local bt version on update#2067Cedric / ViaDézo1er (viadezo1er) wants to merge 1 commit into
Cedric / ViaDézo1er (viadezo1er) wants to merge 1 commit into
Conversation
rum with a daily cron job or manually
Cedric / ViaDézo1er (viadezo1er)
changed the title
Cedric / ViaDézo1er (viadezo1er)
requested review from
Abhijeet Prasad (AbhiPrasad) and
Luca Forstner (lforst)
Luca Forstner (lforst)
requested changes
May 29, 2026
Member
Luca Forstner (lforst)
left a comment
Luca Forstner (lforst)
left a comment
There was a problem hiding this comment.
This is not what we want. Updates should be manual as a minor in bt is a minor in sdk, and a major in bt, is a major in sdk.
There was a problem hiding this comment.
This should not be a .cjs file I think. In general, let's follow https://github.com/getsentry/sentry-cli/blob/master/scripts/install.js or https://blog.sentry.io/publishing-binaries-on-npm/ to the tee. The logs are very intentional there and we should log similar things to ensure people are not confused when installing the package and things fail.
I also have an example repo on how this should look like: https://github.com/lforst/npm-binary-example
Contributor
Author
|
We'll stick with manual version update for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run with a daily cron job or manually.
Regenerate
pnpm-lock.yamlonce thebtbinaries have been pushed tonpmto fix CI.Depends on braintrustdata/bt#208.