Skip to content

fix: Solve dependency issues#102

Draft
ViaDézo1er / cedric (viadezo1er) wants to merge 3 commits intomainfrom
cedric-langchain-package-name-change
Draft

fix: Solve dependency issues#102
ViaDézo1er / cedric (viadezo1er) wants to merge 3 commits intomainfrom
cedric-langchain-package-name-change

Conversation

@viadezo1er
Copy link
Contributor

@viadezo1er ViaDézo1er / cedric (viadezo1er) commented Mar 20, 2026

Fix #112

langchain python pkg got updated, some submodules are now accessible with langchain_classic module

See comparison of submodules between langchain_classic and langchain

setup.py is never used in the dev workflow so that might cause issues since the dependencies used at packaging time are never tested.
The doc extra dependency can probably be deleted, especially since it can cause dependency issues.

@viadezo1er ViaDézo1er / cedric (viadezo1er) marked this pull request as ready for review March 20, 2026 00:04
@viadezo1er ViaDézo1er / cedric (viadezo1er) marked this pull request as draft March 20, 2026 01:01
@viadezo1er ViaDézo1er / cedric (viadezo1er) changed the title fix: Replace langchain with langchain_classic fix: Solve dependency issues Mar 20, 2026
@viadezo1er
Copy link
Contributor Author

ViaDézo1er / cedric (viadezo1er) commented Mar 20, 2026

Unresolved Import Errors — Analysis

Running mise exec -- ty check currently surfaces one error[unresolved-import]:


Module 'py.src.braintrust' has no member 'log_conn'

File affected:
py/src/braintrust/cli/install/redshift.py:7

Import causing the error:

from ... import log_conn, login

Why it fails:

log_conn was renamed to api_conn in commit 20cb94f
("Clean up connection names (#294)", 2024-07-05). The commit updated:

  • py/src/braintrust/logger.py — renamed BraintrustState.log_conn()api_conn() and the module-level log_conn()api_conn()
  • py/src/braintrust/cli/install/api.py — updated call sites

But redshift.py was not included in that commit and was never updated.
log_conn no longer exists anywhere in the codebase — only this stale import remains.

Additionally, log_conn/api_conn are internal and have never been exported from
braintrust/__init__.py, so the relative import from ... import log_conn would
have needed to rely on the wildcard from .logger import * to work at all.


Dependency note: docstring-parser downgrade from 0.17.0 to 0.11

Running make install-deps forces docstring-parser to be downgraded from
0.17.0 to 0.11.x. The chain is:

  1. make install-depspy/Makefile install-dev$(UV) pip install -r requirements-dev.txt
  2. py/requirements-dev.txt lists pydoc-markdown with no version pin
  3. That resolves to pydoc-markdown==4.8.2, whose metadata declares:
    Requires-Dist: docstring-parser (>=0.11,<0.12)
    
  4. That constraint forces docstring-parser down to the latest 0.11.x regardless
    of what was previously installed.

This is an issue as docstring-parser 0.11 conflicts with recent versions of pydantic-ai (0.0.12) and anthropic (0.8.1)..... though when grouping all dependencies together this does not happen, as pydoc-markdown gets resolved to version 2.1.3 as this version does not have a docstring-parser dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Langchain dependency update

1 participant