fix: honor org git metadata settings for experiments#486
Merged
Abhijeet Prasad (AbhiPrasad) merged 2 commits intoJun 3, 2026
Conversation
Experiments now capture commit and branch metadata when an organization has enabled git metadata collection, even if callers do not pass git_metadata_settings explicitly. This restores the expected default behavior for orgs collecting all git fields or selected fields, while keeping metadata disabled for orgs without a saved collection policy.
Abhijeet Prasad (AbhiPrasad)
requested review from
Alex R (alexr17) and
Luca Forstner (lforst)
Contributor
|
lgtm, i jsut checked that js sdk already has this behavior |
Luca Forstner (lforst)
approved these changes
Jun 3, 2026
3 tasks
Abhijeet Prasad (AbhiPrasad)
deleted the
git-metadata-regression-py-0.23.0
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Experiments now capture commit and branch metadata when an organization has enabled git metadata collection, even if callers do not pass git_metadata_settings explicitly.
This restores the expected default behavior for orgs collecting all git fields or selected fields, while keeping metadata disabled for orgs without a saved collection policy.