Keep duplicate devserver evaluators addressable#495
Draft
Ritwij Aryan Parmar (RitwijParmar) wants to merge 1 commit into
Draft
Keep duplicate devserver evaluators addressable#495Ritwij Aryan Parmar (RitwijParmar) wants to merge 1 commit into
Ritwij Aryan Parmar (RitwijParmar) wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #366 by making duplicate
eval_nameregistrations in the dev server addressable instead of silently collapsing to the last evaluator.What changed:
eval_nameonly/listkeys and/eval { name }continue to work/listexposes disambiguated keys likeshared-project#1/shared-project#2plusidand originalnamemetadata/evalaccepts the newidfield, also accepts the disambiguated/listkey asname, and returns a 409 with candidates when the original name is ambiguousThis avoids the startup-time raise/warn stopgap and keeps both evaluators reachable.
Tests
PYTHONPATH=py/src .venv/bin/python -m pytest py/src/braintrust/devserver/test_server_integration.py::test_devserver_keeps_duplicate_eval_names_addressable py/src/braintrust/devserver/test_server_integration.py::test_eval_falls_back_to_evaluator_project_id_when_request_omits_or_empty_it py/src/braintrust/devserver/test_server_integration.py::test_eval_request_project_id_overrides_evaluator -qPYTHONPATH=py/src .venv/bin/python -m compileall -q py/src/braintrust/devserver/server.py py/src/braintrust/devserver/schemas.py py/src/braintrust/devserver/test_server_integration.pygit diff --check