Fix Eval trace structure inconsistencies#119
Merged
David Elner (delner) merged 1 commit intomainfrom Mar 17, 2026
Merged
Conversation
Abhijeet Prasad (AbhiPrasad)
approved these changes
Mar 17, 2026
This was referenced Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are numerous issues with the Eval trace structure when compared to the Java SDK (the other OTel-based implementation) Python, and TypeScript traces.
Changes
"score"span with all scores aggregated on it"score"span as a direct child of the eval span, matching Java/Python/TSpurpose: "scorer"on score spansspan_attributesonly had{type: "score"}span_attributesincludes{type: "score", name: scorer_name, purpose: "scorer"}— used by the platform to filter scorer spans from cost/latency calculationsinput_jsonoroutput_jsoninput_json(input, expected, output, metadata) andoutput_json(scores hash), matching Python/TS expected outputinput_jsonnot wrapped"hello"){input: "hello"}, matching Java SDKoutput_jsonnot wrapped"HELLO"){output: "HELLO"}, matching Java SDKmetadataon eval spanbraintrust.metadataon the eval span, matching Java SDKoutput_jsonon eval span when task errorsoutput_jsonattribute set at all{output: null}, matching Java SDKspan_attributes,input_json,expected,metadata,originwere set after task+scorers, so they were skipped on task errortracer.in_span("eval")which inherits any active parent span (e.g., a Sidekiq job span)tracer.start_root_span("eval")so each eval case starts its own independent trace, matching Java'ssetNoParent()