Flag restructuring for bt setup#105
Merged
ViaDézo1er / cedric (viadezo1er) merged 14 commits intomainfrom Apr 14, 2026
Merged
Conversation
ViaDézo1er / cedric (viadezo1er)
force-pushed
the
cedric-better-dx-pr1
branch
from
d13121f to
cde4bc9
Compare
|
Latest downloadable build artifacts for this PR commit
Available artifact names
|
Contributor
Author
|
pre-commit run --all-files does not show any issue locally... |
Rename/restructure CLI flags to improve UX without changing core behaviour: BaseArgs: - Remove --quiet/-q (BRAINTRUST_QUIET) and --no-input; quiet output is now the global default (set_quiet(true) in configure_output). - Add verbose: bool as #[arg(skip)] — subcommands set it at runtime; set up output messages are shown only when verbose is active. SetupArgs: - --no-mcp-skill → --no-skills + --no-mcp (orthogonal opt-outs) - Add --no-instrument (opt-out; instrument is the new default) - Add --tui / --background (replace --interactive / --quiet in wizard) - Add --language (repeatable), --interactive/-i, --verbose/-v at top level AgentsSetupArgs: - --agent (repeatable Vec) → --agent (single Option); drop AgentArg::All - --yes removed from CLI (#[arg(skip)]); programmatic callers still set yes:true - Add --no-workflow (conflicts with --workflow) AgentsMcpSetupArgs: - Same agents→agent and yes→skip treatment InstrumentSetupArgs: - --quiet → --background (run agent non-interactively, show spinner) - --interactive → --tui (run agent in interactive TUI mode) - --yes → #[arg(skip)] - Add skip_launch: bool (#[arg(skip)]) for future wizard use resolve_selected_agents: signature changes from &[AgentArg] to Option<AgentArg>; None auto-detects all installed agents as before. All call sites, struct literals in tests, and BaseArgs literals in auth/switch/traces/functions updated to match. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- `bt setup instrument --interactive` now accepted as alias for --tui - `bt setup instrument --quiet` now accepted as alias for --background - `bt setup --no-mcp-skill` now accepted as hidden alias for --no-skills --no-mcp - Explicit error when --json and --tui are both passed
ViaDézo1er / cedric (viadezo1er)
force-pushed
the
cedric-better-dx-pr1
branch
from
141f4a8 to
0c32a06
Compare
ViaDézo1er / cedric (viadezo1er)
force-pushed
the
cedric-better-dx-pr1
branch
from
57c044b to
003b931
Compare
ViaDézo1er / cedric (viadezo1er)
changed the title
ViaDézo1er / cedric (viadezo1er)
requested a review
from Abhijeet Prasad (AbhiPrasad)
ViaDézo1er / cedric (viadezo1er)
force-pushed
the
cedric-better-dx-pr1
branch
from
dd8eb2c to
7a1885b
Compare
move CLI coverage to integration tests
Abhijeet Prasad (AbhiPrasad)
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mechanical rename/removal of CLI flags:
--quiet→--verbose(invert default)--agents(repeatable) →--agent(single), removeAgentArg::All--no-mcp-skill→--no-skills+--no-mcp--no-instrument,--tui/--background,--no-workflow--yesto#[arg(skip)]--interactive/-iflag, that more or less preserves the previous behavior of asking all questionsPart 1 of #94