fix: clean up temp file on failed config save#173
Open
Cedric / ViaDézo1er (viadezo1er) wants to merge 1 commit intomainfrom
Open
fix: clean up temp file on failed config save#173Cedric / ViaDézo1er (viadezo1er) wants to merge 1 commit intomainfrom
Cedric / ViaDézo1er (viadezo1er) wants to merge 1 commit intomainfrom
Conversation
Cedric / ViaDézo1er (viadezo1er)
force-pushed
the
cedric/temp-file-cleanup
branch
from
f4d8905 to
85a6763
Compare
Cedric / ViaDézo1er (viadezo1er)
requested review from
Abhijeet Prasad (AbhiPrasad) and
Parker Henderson (parkerhendo)
|
Latest downloadable build artifacts for this PR commit
Available artifact names
|
Abhijeet Prasad (AbhiPrasad)
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch from manual
.tmpfile totempfile::NamedTempFile, should help to clean the file in case of failure.Part of #165