feat(helm): add optional custom TLS CA support via braintrust-secrets #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for API (GCP Memorystore)
… enabled for brainstore only when locking is set to redis.
mdeeks
reviewed
Oct 27, 2025
mdeeks
reviewed
Oct 27, 2025
mdeeks
reviewed
Oct 28, 2025
mdeeks
reviewed
Oct 28, 2025
mdeeks
changed the title
mdeeks
changed the title
jeffmccollum
added a commit
that referenced
this pull request
Nov 4, 2025
…#39) * Update Chart version to 2.1.0 * Pull Request Proposal for Braintrust Helm Chart: Redis TLS CA support for API (GCP Memorystore) * update redis tls to be a global setting, enabled only for google, and enabled for brainstore only when locking is set to redis. * add realtime url to api and add redis secret * simplify value and support any cloud * add BRAINSTORE_REDIS_URL (#40) * rename customRedisTLSCABundle to customTLSCABundle * rename --------- Co-authored-by: Braintrust Bot <215900051+braintrust-bot[bot]@users.noreply.github.com> Co-authored-by: Jeff McCollum <jeff@braintrustdata.com> Co-authored-by: Ken Jiang <39507362+knjiang@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds optional support for passing in a custom TLS Certificate Authority Bundle. The main use case for this is to provide a mechanism for the API and Brainstore services to trust Google Memorystore TLS certificates that are not signed by a trusted public CA. This feature can be used in a generic way to add a custom trust chain for any TLS connections established by the braintrust services.
CA_PEMkey in the existing Kubernetes Secretbraintrust-secretsinto the API and Brainstore pods.NODE_EXTRA_CA_CERTSon the API pod andSSL_CERT_FILEon the brainstore pods to that bundle when enabled.customTLSCABundle