Merged
Conversation
Comment on lines
+1210
to
+1224
| topPReasoningModelParam: { | ||
| "chat-completions": { | ||
| model: OPENAI_CHAT_COMPLETIONS_MODEL, | ||
| messages: [{ role: "user", content: "Say hi." }], | ||
| top_p: 0.9, | ||
| }, | ||
| responses: { | ||
| model: OPENAI_RESPONSES_MODEL, | ||
| input: [{ role: "user", content: "Say hi." }], | ||
| top_p: 0.9, | ||
| }, | ||
| anthropic: null, | ||
| google: null, | ||
| bedrock: null, | ||
| }, |
Contributor
There was a problem hiding this comment.
can we delete and just re-use topPParam they r basically identilca.
Contributor
Author
There was a problem hiding this comment.
yeah ill incorporate it into the one above.
Contributor
Author
There was a problem hiding this comment.
Ok nm I think i would lose OpenAI to OpenAI test coverage for: “a Chat Completions request already targeting a reasoning model contains invalid top_p, and Lingua strips it.”.
Ken Jiang (knjiang)
approved these changes
Apr 15, 2026
Alex Z (CLowbrow)
pushed a commit
that referenced
this pull request
Apr 17, 2026
Opus 4.7 does not accept the temperature parameter. Mirrors the OpenAI top_p fix (#196) by adding a model-transform pipeline to the Anthropic provider and wiring it into request_from_universal so temperature is stripped regardless of whether it came from canonical params or passthrough extras. Handles bare, dated, Bedrock, and Vertex model ids. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not all openai models can handle it.