Skip to content

Update openai,anthropic,google provider types#249

Merged
Alex Z (CLowbrow) merged 1 commit into
mainfrom
update-provider-types-4e52d59b-26241642947
May 21, 2026
Merged

Update openai,anthropic,google provider types#249
Alex Z (CLowbrow) merged 1 commit into
mainfrom
update-provider-types-4e52d59b-26241642947

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

Automated update of Lingua provider types.

Providers: openai,anthropic,google

Validation

  • Ran ./pipelines/generate-provider-types.sh for each requested provider
  • Ran make generate-types
  • Ran cargo fmt --all
  • Ran cargo build --all-features
  • Ran cargo clippy --all-targets --all-features -- -D warnings

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ec687e0238

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "Codex (@codex) review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "Codex (@codex) address that feedback".

Comment on lines +4934 to +4935
#[ts(type = "unknown")]
pub size: Option<serde_json::Value>,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restore string typing for ImageGenTool.size

ImageGenTool.size was widened from Option<String> to Option<serde_json::Value>, but the schema docs on this field still define it as WIDTHxHEIGHT string values (plus known string presets). This removes compile-time validation and allows non-string payloads (e.g., objects/numbers) to be serialized into tools[].size, which can now pass local typing but fail at provider request time. Keeping this field typed as a string (or a stricter string wrapper) preserves the provider contract and avoids avoidable runtime request errors.

Useful? React with 👍 / 👎.

@CLowbrow Alex Z (CLowbrow) merged commit 1ab5b28 into main May 21, 2026
6 checks passed
Alex Z (CLowbrow) added a commit that referenced this pull request May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants