add google test cases #74
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 2, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
knjiang
force-pushed
the
01-28-add_google_test_cases
branch
from
9cbab07 to
ff40a19
Compare
knjiang
force-pushed
the
01-26-add_google_roundtrip
branch
from
68f389d to
1b05794
Compare
knjiang
force-pushed
the
01-28-add_google_test_cases
branch
from
ff40a19 to
f62df6a
Compare
knjiang
force-pushed
the
01-28-add_google_test_cases
branch
from
f62df6a to
795c523
Compare
knjiang
commented
Feb 3, 2026
Comment on lines
+121
to
+123
| serde_json::to_string_pretty(&truncate_large_values(original_json, 1000)).unwrap(), | ||
| serde_json::to_string_pretty(&truncate_large_values(roundtripped_json, 1000)) | ||
| .unwrap() |
Contributor
Author
There was a problem hiding this comment.
imageConfigParam generated a really large image so added a truncate_large_values helper for scripts so claude wouldn't run out of context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds comprehensive google test cases for all parameters. surprisingly most of the code worked for messages out of the box.
note: