feat: add instrument.ts harness bridge by viadezo1er · Pull Request #26 · braintrustdata/spark

Cedric / ViaDézo1er (viadezo1er) · 2026-05-11T21:59:20Z

Adds src/instrument.ts: the bridge between the wizard and the harness.

ensureBtOnPath — installs bt via curl -fsSL https://bt.dev/cli/install.sh | bash on macOS/Linux if it's not already on PATH
writePromptToTemp — writes the rendered prompt to a temp file and returns the path
buildHarnessCommand — constructs the copy-paste command to resume the agent session
runInstrumentation — resolves the harness binary, spawns it with BRAINTRUST_API_KEY in the env, and returns the trace permalink and resume command when done

LOGO_PATTERN only matched ▀▄ (half-blocks from PNG rendering) but not █ (full-blocks from the fallback logo). In environments where the PNG fails to load, all three logo-presence assertions would fail. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

release undici connection when rate-limited

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Luca Forstner (lforst) · 2026-05-12T11:27:43Z

+const HARNESS_PACKAGE_BIN =
+  "@braintrust/bt-wizard-harness/bin/bt-wizard-harness.mjs";
+
+function resolveHarnessPath():
+  | { readonly ok: true; readonly path: string }
+  | { readonly ok: false; readonly reason: string } {
+  try {
+    const require = createRequire(import.meta.url);
+    return { ok: true, path: require.resolve(HARNESS_PACKAGE_BIN) };
+  } catch (err) {
+    return {
+      ok: false,
+      reason: err instanceof Error ? err.message : String(err),
+    };
+  }
+}
+


this is funky

Addressed in 21edc1c.

Replace the single password prompt for provider API keys with collectCredentials(), which loops over provider.credentials for multi-field providers (Bedrock, Vertex, Azure) and falls back to a single secret prompt for single-key providers. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

All wizard source, tests, and build configs move from the repo root into packages/braintrust-wizard so nothing lives half at root / half in packages. Root package.json becomes a lean workspace root that delegates scripts via --filter and -r. The bt-wizard-harness scaffold gains ESLint, TypeScript, and Prettier configs plus the corresponding devDependencies and scripts.

parseArgs is async but was called without await, making parsed a Promise and causing parsed.options to be undefined at runtime. Awaiting it fixes the crash. The manual --help branch and helpText export are removed since yargs' built-in .help() already handles --help by printing and exiting during parseAsync.

Drop bin/files/typings from bt-wizard-harness (no source files yet), fix typebox → @sinclair/typebox, and resolve two exactOptionalPropertyTypes errors in clack-wizard.ts and providers.test.ts so pnpm -r run typings passes.

All wizard source, tests, and build configs move from the repo root into packages/braintrust-wizard so nothing lives half at root / half in packages. Root package.json becomes a lean workspace root that delegates scripts via --filter and -r. The bt-wizard-harness scaffold gains ESLint, TypeScript, and Prettier configs plus the corresponding devDependencies and scripts.

outdated comment

…ing-pi-harness

Replace the providerEnvVar/providerApiKey pair with providerCredentials?: Record<string, string>, spread directly into the child process env. Supports multi-credential providers (Bedrock, Vertex, Azure) alongside existing single-key providers.

Cedric / ViaDézo1er (viadezo1er) · 2026-05-15T18:54:33Z

Rebased against cedric/revamp-onboarding-pi-harness, only change was a comment.

Declare a bin entry in @braintrust/bt-wizard-harness and resolve it from the wizard via import.meta.resolve + fileURLToPath. Drops the createRequire shim and the harness-not-found result branch — if resolution fails, that's a broken install, so let it throw at module load.

Cedric / ViaDézo1er (viadezo1er) · 2026-05-15T19:09:32Z

Fixed formatting.

Cedric / ViaDézo1er (viadezo1er) and others added 2 commits May 11, 2026 15:23

feat: add WizardSigninAuthClient for browser-mediated login flow

b51b67b

Cedric / ViaDézo1er (viadezo1er) force-pushed the cedric/revamp-onboarding-pi-harness branch from 631014f to 362e114 Compare May 11, 2026 22:33

Cedric / ViaDézo1er (viadezo1er) force-pushed the cedric/revamp-onboarding-pi-instrument branch 2 times, most recently from 2d58db1 to c91eb23 Compare May 11, 2026 23:08

Cedric / ViaDézo1er (viadezo1er) force-pushed the cedric/revamp-onboarding-pi-harness branch from 362e114 to e944e5f Compare May 11, 2026 23:08

Cedric / ViaDézo1er (viadezo1er) and others added 4 commits May 11, 2026 17:24

chore: max 3min rate limit for polling

bddfc24

chore: add request timeout

bfff9ac

release undici connection when rate-limited

feat: Braintrust API client

b77521c

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat: expand wizard-copy with new prompts and helpers

ca8c7c0

Luca Forstner (lforst) requested changes May 12, 2026

View reviewed changes

Cedric / ViaDézo1er (viadezo1er) force-pushed the cedric/revamp-onboarding-pi-harness branch from e944e5f to 9505984 Compare May 12, 2026 19:40

Cedric / ViaDézo1er (viadezo1er) force-pushed the cedric/revamp-onboarding-pi-instrument branch from c91eb23 to 8c28ff9 Compare May 12, 2026 19:40

Cedric / ViaDézo1er (viadezo1er) added 3 commits May 12, 2026 13:01

feat: use open to open web page

ec4fabb

feat: use open to open web page

d0ab852

feat: add cleanup message helpers

8e021d0

Cedric / ViaDézo1er (viadezo1er) force-pushed the cedric/revamp-onboarding-pi-instrument branch from 8c28ff9 to 75a11f8 Compare May 12, 2026 20:33

Cedric / ViaDézo1er (viadezo1er) force-pushed the cedric/revamp-onboarding-pi-harness branch 2 times, most recently from 33024f9 to 602893c Compare May 12, 2026 22:02

Cedric / ViaDézo1er (viadezo1er) force-pushed the cedric/revamp-onboarding-pi-instrument branch from 75a11f8 to 2fc0466 Compare May 12, 2026 22:02

Cedric / ViaDézo1er (viadezo1er) added 8 commits May 12, 2026 15:38

feat: add fuzzy search prompt helper

285eb99

feat: add git repo detection and .env writing helpers

e3627c2

feat: add fuzzy search prompt helper

4fc525b

feat: add language/framework detection

8102508

feat: add CLI argument parser

184a949

feat: add LLM providers list

0adc6a0

feat: add instrumentation prompt template

9dfc5e2

feat: implement clack wizard flow

28c7501

Cedric / ViaDézo1er (viadezo1er) force-pushed the cedric/revamp-onboarding-pi-harness branch from 602893c to a17984f Compare May 12, 2026 22:38

Cedric / ViaDézo1er (viadezo1er) force-pushed the cedric/revamp-onboarding-pi-instrument branch from 2fc0466 to 1899c3c Compare May 12, 2026 22:38

Cedric / ViaDézo1er (viadezo1er) and others added 14 commits May 14, 2026 13:40

chore: prompt comment

063ec6d

feat: scaffold bt-wizard-harness workspace package

f0e9217

fix: await async git helpers in clack-wizard

0847d33

fix: clean up harness scaffold and fix typings errors

071d5ea

Drop bin/files/typings from bt-wizard-harness (no source files yet), fix typebox → @sinclair/typebox, and resolve two exactOptionalPropertyTypes errors in clack-wizard.ts and providers.test.ts so pnpm -r run typings passes.

chore: drop phantom harness dep from braintrust-wizard

83effa0

chore: migrate pi deps to @earendil-works/* namespace

8e7e1c4

feat: add path-guard extension

7a6cd2e

feat: add bt, curl, git, request-command tool extensions

8257160

feat: add package-manager tool extension

02ebeea

feat: add bt-wizard-harness launcher binary

7a4116d

Cedric / ViaDézo1er (viadezo1er) changed the base branch from cedric/revamp-onboarding-pi-harness to main May 15, 2026 16:56

Cedric / ViaDézo1er (viadezo1er) force-pushed the cedric/revamp-onboarding-pi-instrument branch from 737e73e to 31052d3 Compare May 15, 2026 17:18

Cedric / ViaDézo1er (viadezo1er) added 2 commits May 15, 2026 10:51

fix: empty llm key crash the setup

e4f0967

outdated comment

Merge remote-tracking branch 'origin/main' into cedric/revamp-onboard…

6ed7a43

…ing-pi-harness

Cedric / ViaDézo1er (viadezo1er) marked this pull request as ready for review May 15, 2026 18:44

Cedric / ViaDézo1er (viadezo1er) added 2 commits May 15, 2026 11:54

feat: add instrument.ts harness bridge

13858e8

Cedric / ViaDézo1er (viadezo1er) force-pushed the cedric/revamp-onboarding-pi-instrument branch from e95def8 to d332b37 Compare May 15, 2026 18:54

Cedric / ViaDézo1er (viadezo1er) mentioned this pull request May 15, 2026

feat: wire PI instrumentation into wizard flow #27

Merged

Cedric / ViaDézo1er (viadezo1er) force-pushed the cedric/revamp-onboarding-pi-instrument branch from 212dae0 to 21edc1c Compare May 15, 2026 19:09

Luca Forstner (lforst) approved these changes May 18, 2026

View reviewed changes

Cedric / ViaDézo1er (viadezo1er) requested a review from Luca Forstner (lforst) May 18, 2026 16:15

Cedric / ViaDézo1er (viadezo1er) merged commit 9c0ad32 into main May 18, 2026
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add instrument.ts harness bridge#26

feat: add instrument.ts harness bridge#26
Cedric / ViaDézo1er (viadezo1er) merged 45 commits into
mainfrom
cedric/revamp-onboarding-pi-instrument

Cedric / ViaDézo1er (viadezo1er) commented May 11, 2026 •

edited

Loading

Uh oh!

Luca Forstner (lforst) May 12, 2026

Uh oh!

Cedric / ViaDézo1er (viadezo1er) May 15, 2026

Uh oh!

Cedric / ViaDézo1er (viadezo1er) commented May 15, 2026

Uh oh!

Cedric / ViaDézo1er (viadezo1er) commented May 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Cedric / ViaDézo1er (viadezo1er) commented May 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Luca Forstner (lforst) May 12, 2026

Choose a reason for hiding this comment

Uh oh!

Cedric / ViaDézo1er (viadezo1er) May 15, 2026

Choose a reason for hiding this comment

Uh oh!

Cedric / ViaDézo1er (viadezo1er) commented May 15, 2026

Uh oh!

Cedric / ViaDézo1er (viadezo1er) commented May 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Cedric / ViaDézo1er (viadezo1er) commented May 11, 2026 •

edited

Loading