Cedric/flag for ci#30
Merged
Merged
Conversation
a79f3ed to
9c52d3e
Compare
Luca Forstner (lforst)
approved these changes
May 12, 2026
23527ea to
3e74894
Compare
9c52d3e to
ef4c4d8
Compare
ef4c4d8 to
1555aa7
Compare
1555aa7 to
717d635
Compare
c1126cc to
cfe2aa8
Compare
…UST_SPARK_API_KEY, BRAINTRUST_SPARK_PROJECT_ID, BRAINTRUST_SPARK_PROVIDER, and BRAINTRUST_SPARK_PROVIDER_API_KEY env vars for CI/script use
cfe2aa8 to
ff32873
Compare
Luca Forstner (lforst)
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal is to allow us to eval spark against test apps.
As a user, be warned: we are not expecting you to use these flags. We may remove or change them without any warning.
Add
BRAINTRUST_SPARK_INSTRUMENT,BRAINTRUST_SPARK_YOLO,BRAINTRUST_SPARK_API_KEY,BRAINTRUST_SPARK_PROJECT_ID,BRAINTRUST_SPARK_PROVIDER, andBRAINTRUST_SPARK_PROVIDER_API_KEYenv vars to allow spark to be used by scripts (useful for CI).BRAINTRUST_SPARK_YOLOalso tweaks the prompt to warn the agent that there isn't any user to answer the questions.Is it ok? It means we would be evaluating something that isn't what the users will actually experience.
BRAINTRUST_SPARK_YOLOimpliesBRAINTRUST_SPARK_INSTRUMENT. Keeping the 2 flags separate allows to test how much can be done before asking questions to the user.Azure, Vertex, Bedrock, custom llm providers are not handled.
Removes
CRANK_ENABLE_TELEMETRYmention from the help that was added in preparation for telemetry, before telemetry was postponed.