Skip to content

adding movflags and copyinkf params#14

Merged
bramp merged 1 commit intomasterfrom
unknown repository
Jun 5, 2016
Merged

adding movflags and copyinkf params#14
bramp merged 1 commit intomasterfrom
unknown repository

Conversation

@nsilberman
Copy link
Copy Markdown
Contributor

No description provided.

@nsilberman nsilberman mentioned this pull request Mar 30, 2016
@nsilberman
Copy link
Copy Markdown
Contributor Author

hmmm, some issues with README or version number ? not sure what to do @bramp

@bramp
Copy link
Copy Markdown
Owner

bramp commented Mar 30, 2016

Your change looks good! However, for some reason Travis is reporting the build broken. I need to fix that before I will accept.

Another comment. movflags is only applicable to mov, mp4, ismv? Thus far (as far as I know) all the arguments I set are generic, that apply to all containers. I don't have a good solution to ensuring that container specific settings can only be applied when that container is in use. So I might also think about that before accepting, unless you have suggests?

@nsilberman
Copy link
Copy Markdown
Contributor Author

about movflags, good point. Why not add some test requirements like checkNotNull but for codecs
You can group codecs by "family" and maybe reference some options accepted for output (and maybe have to execute a ffprobe ?)

@bramp bramp merged commit d265ebf into bramp:master Jun 5, 2016
@bramp
Copy link
Copy Markdown
Owner

bramp commented Jun 5, 2016

Thanks I accepted the PR. I still don't have a good solution for checking the correct Codec. I don't want to get into a situation where I need to know an extensive list of codecs.

@nsilberman
Copy link
Copy Markdown
Contributor Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants