Implement adding metadata to output video.#20
Merged
bramp merged 2 commits intobramp:masterfrom Jun 5, 2016
mandrakey:output_meta_tags
Merged
Implement adding metadata to output video.#20bramp merged 2 commits intobramp:masterfrom mandrakey:output_meta_tags
bramp merged 2 commits intobramp:masterfrom
mandrakey:output_meta_tags
Conversation
| public String video_preset; | ||
| public String video_filter; | ||
| public String video_filter_complex; | ||
| public List<String> meta_tags; |
Owner
There was a problem hiding this comment.
Could you call this video_meta_tags
Owner
|
Very cool. I added a few comments, that should be easy to fix. |
* meta_tags -> video_meta_tags * wrap -metadata arguments in quotes * remove quotes from metadata values when adding since they break the command
Contributor
Author
|
I have to leave now until tonight - if any other issues arise, I'll gladly fix them later. |
Owner
|
Thanks! I made a couple of minor changes, and merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a simple implementation for adding metadata to the output video.
I realised it using an ArrayList, storing each "-metadata" value as a String. Thought about using a HashMap, but I didn't see a real reason for that.