Merged
Conversation
bramp
requested changes
Mar 31, 2020
|
|
||
| } finally { | ||
| p.destroy(); | ||
| if (p != null) { |
Contributor
Author
There was a problem hiding this comment.
well, processBuilder should not return null, however, try to pass non-configured smaple to probe() method and you get NPE in destroy, as tests setUp is quite fragile, once you misconfigure it (what I obviously done in the first run) - mock could return null for process then the test crashes hiding real reason - and that's become a puzzle.
Formally, I agree check is not needed for production code and code should not contain code for tests as it makes it more tricky to support. Ideally, setUp/before needs to be tuned to make more robbust and crash on incorrect file rather then return null.
Contributor
Author
|
@bramp, that was quick. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix implements chapters support by FFProbe, issue #212