feat(FFmpegBuilder): support -f for input#22
Merged
bramp merged 1 commit intobramp:masterfrom May 23, 2016
davinkevin:master
Merged
feat(FFmpegBuilder): support -f for input#22bramp merged 1 commit intobramp:masterfrom davinkevin:master
bramp merged 1 commit intobramp:masterfrom
davinkevin:master
Conversation
In order to support the input format parameters, a format attribute have been added to the FFmpegBuilder class and handle in the build method. The parameter is mandatory for some operation like concatenation without re-encode (https://www.ffmpeg.org/ffmpeg-formats.html#concat). With this extra parameter, we can generate a command line like this : /usr/local/bin/ffmpeg -f concat -i /path/to/file.txt -vcodec copy -acodec copy /path/to/file.mp4
davinkevin
added a commit
to davinkevin/Podcast-Server
that referenced
this pull request
May 22, 2016
In version 3.0.2, the concat operation doesn't working with FILE_1|FILE_2|FILE_3 syntax, so we have to create an intermediate file which contains all the information about the source to be concatenated. This modification is linked to the need of a better implementation for ffmpeg command line call. Linked to #68 and waiting for bramp/ffmpeg-cli-wrapper#22
Contributor
Author
|
@bramp Do you see any problem with this PR ? I'm currently working on a project using ffmpeg-cli-wrapper (https://github.com/davinkevin/Podcast-Server), but this functionality (in this PR) is missing, so now I'm working on a SNAPSHOT locally released from my fork, but I would like to know if it will be possible to use the official release with PR in a near future. Thanks for your help |
Owner
|
Thanks. Looks good to me! |
Owner
|
I'll roll a new release shortly. |
Contributor
Author
|
Thanks. In futur, I will surely need to have the functionality #21 so I will discuss with you to find the best way to implement it, and like that, I could do a PR ;) Thanks again and have a good day |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to support the input format parameters, a format attribute have been added to the FFmpegBuilder class and handle in the build method.
The parameter is mandatory for some operation like concatenation without re-encode (https://www.ffmpeg.org/ffmpeg-formats.html#concat). With this extra parameter, we can generate a command line like this : /usr/local/bin/ffmpeg -f concat -i /path/to/file.txt -vcodec copy -acodec copy /path/to/file.mp4