Added method for using two pass with progress to class FFmpegExecutor #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Sorry for the delay! From memory, the reason two-pass was done manually, because there were certain scenarios where you needed/wanted to change flag, options between passes, and/or capture the output from the first pass. But honestly I don't remember the exact reason. Otherwise your change looks good. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The class
TwoPassFFmpegJobhad a method in it for including aProgressListener, butFFmpegExecutordid not have a method that would employ it. I simply added the method to the executor, tested it and it works fine.I am curious, however ...
ffmpeghas a command-line switch for two pass encoding, but this library seems to accomplish this manually ... why not just use the option that is built intoffmpeg?