feat(builder): set log level programmatically#26
Merged
bramp merged 1 commit intobramp:masterfrom Jun 19, 2016
Merged
Conversation
I'v create a enum with all the possible value and define a default value in the builder to the previous one (ERROR). The user can set verbosity with method `setVerbosity(Verbosity v)`. This will help us to develop the issue bramp#21 because we need a certain level of information to display / send the progresion of a ffmpeg operation
Owner
|
The code looks good, but I avoided added this method, explicitly due to #21. Because I didn't know how to handle the case that a user setVerbosity(QUIET), and we are still expected to parse the output. Perhaps discussion is needed on the parsing, but we could provide two interfaces. 1) Run with us parsing the output, or 2) Run with the user receiving the output and they can set verbosity? I think until we have good answers it might be best to make this new method private, and document that we will open it in future when #21 is resolved. |
Contributor
Author
Owner
|
Yes, we should sync :) Lets move discussion to #21, and start proposing how it will work, and what its goals are. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'v created an enum with all the possible value and define a default value in the builder to the previous hard coded level (ERROR). The user can set verbosity with method
setVerbosity(Verbosity v).This will help us to develop the issue #21 because we need a certain level of information to display / send the progresion of a ffmpeg operation