Fix #209 -user-agent tag is not supported#270
Merged
bramp merged 1 commit intobramp:masterfrom Oct 9, 2022
Merged
Conversation
Owner
|
How long ago was this deprecated? I wonder if we need to start switching based on the ffmpeg version.... Or maybe that's too much work. |
Collaborator
Author
|
Not sure. The oldest version I can find without too much effort is 2.8.15. The problem wouldn't be switching based on the version but finding on what version we need to switch. |
Owner
|
Ah, let's just bump to the most recent version then. Especially if we plan to bump the library version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
-user-agenttag has been deprecated, the new tag is-user_agent.This pr replaces the deprecated form with the current format.
Fix #209