Change FFmpegChapter#id type to long#310
Merged
bramp merged 1 commit intobramp:masterfrom Mar 10, 2024
Merged
Conversation
bramp
reviewed
Mar 10, 2024
|
|
||
| assertThat(info.getChapters().get(0).id, is(6613449456311024506L)); | ||
| assertThat(info.getChapters().get(1).id, is(-4433436293284298339L)); | ||
| } |
Owner
There was a problem hiding this comment.
Are chapter IDs allowed to be negative?
Collaborator
Author
There was a problem hiding this comment.
Very good question, I just checked in the ffmpeg source.
They use int64_t, which is 64bit signed, so type long and negative values are supported.
I'm not sure, if ffmpeg itself will produce negative numbers, might be compatibility with other software.
Edit:
FFmpeg AVChapter
bramp
approved these changes
Mar 10, 2024
Owner
bramp
left a comment
bramp
left a comment
There was a problem hiding this comment.
Looks great, thanks. Just one question before I merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #296.
The data provided in the issue is sadly not complete, but using an existing file and adding the chapter information I could re-create a minimal test to accompany the fix