Merged
Conversation
| * Helper class with commonly used methods | ||
| */ | ||
| public final class FFmpegUtils { | ||
| public abstract class FFmpegUtils { |
Owner
There was a problem hiding this comment.
I would expect anyone to extend this class (which is what abstract implies). Instead I used a final class, with private constructor. http://stackoverflow.com/questions/25223553/how-can-i-create-an-utility-class
Owner
There was a problem hiding this comment.
typo: I wouldn't expect anyone to extend this class (which is what abstract implies). Instead I used a final class, with private constructor.
Owner
There was a problem hiding this comment.
If you can change this back to public final class FFmpegUtils I can accept the pull request.
Owner
|
There were other unrelated changed in this that were good. Feel free to reopen and rename the problem. |
stonio
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.