Skip to content

Conversation

@MasonM
Copy link
Contributor

@MasonM MasonM commented Oct 22, 2018

In WebSequenceDiagrams, title messages aren't delimited by a :. This adds support for that using an exclusive start condition in the JISON grammar, while preserving backwards compatibility. I also added a couple tests.

I didn't commit the generated dist/*.js files so this is easier to review. Let me know if I should push those up.

In WebSequenceDiagrams, title messages aren't delimited by a :. This adds
support for that using an exclusive start condition in the JISON grammar, while
preserving backwards compatibility. I also added a couple tests.
@MasonM
Copy link
Contributor Author

MasonM commented Oct 25, 2018

Here's the new railroad diagam:
statement

Copy link
Owner

@bramp bramp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@MasonM
Copy link
Contributor Author

MasonM commented Oct 26, 2018

@bramp Thanks for the quick review! I entered #203 to update the RR diagram. Let me know if you need anything else.

@bramp bramp merged commit 0b252fa into bramp:master Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants