fix(web): open search hits in Ember, not the source site#109
Merged
Conversation
Search typeahead results were external links (<a href=article-url target=_blank>), so clicking left Ember for the original site. Render them as buttons that switch to the search view (loading the results) and select the article, opening it in the reader like any other card.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Search typeahead results were external links (
<a href=article-url target=_blank>), so clicking a result left Ember for the original article site instead of opening the article card. Now they are buttons that switch to the search view (loading the results) and select the article, opening it in the reader like any other card.Cherry-picked from develop (
8d13be8). Merging redeploys the demo site (pages.yml rebuilds the demo SPA from web/ on push to main).