fix: huddle lookup resolves by league family, not exact season ID#97
Merged
Conversation
When switching to a past season, selectedLeagueId changes to that season's league ID which never matched the huddle (stored with the most recent season's ID). This caused Settings, Commissioner, and Announcements to appear empty on any non-current season. Fix: new useSelectedLeagueHuddle() hook in useHuddles.ts resolves the family root of both selectedLeagueId and each huddle's leagueId via buildFamilyRootMap. Fast path: exact match as before. Slow path: walk the family chain and match on root. Applied to: - CommissionerPage (replaced local useSelectedLeagueHuddle) - LeagueSettingsPage - Announcements widget - TeamPage (selectedLeagueHuddleId for awards/trophies)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Switching to a past season caused League Settings, Commissioner panel, and Announcements to appear empty. The huddle stores the
leagueIdof the season it was linked to (typically the most recent one), but each season in a family has its ownleagueId. An exact match only works for that one season.Fix
New
useSelectedLeagueHuddle()hook inuseHuddles.tsresolves the family root of bothselectedLeagueIdand each huddle'sleagueIdviabuildFamilyRootMap, then matches on root instead of raw ID.previousLeagueRefchain to find the shared ancestorApplied to
CommissionerPage— replaced localuseSelectedLeagueHuddlewith the shared hookLeagueSettingsPage— same inline find replacedAnnouncementswidget — sameTeamPage—selectedLeagueHuddleIdfor custom awards and trophy control