adiciona validacao no Makefile para OS Windows#455
Merged
camilamaia merged 2 commits intobrazilian-utils:mainfrom Dec 19, 2024
Merged
adiciona validacao no Makefile para OS Windows#455camilamaia merged 2 commits intobrazilian-utils:mainfrom
camilamaia merged 2 commits intobrazilian-utils:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #455 +/- ##
=======================================
Coverage 99.83% 99.83%
=======================================
Files 21 21
Lines 612 612
=======================================
Hits 611 611
Misses 1 1 ☔ View full report in Codecov by Sentry. |
Contributor
Author
Antes
Depois
|
Contributor
Author
Antes
Depois
|
vianaz
changed the title
camilamaia
approved these changes
Dec 19, 2024
Member
camilamaia
left a comment
camilamaia
left a comment
There was a problem hiding this comment.
@vianaz Muito obrigada pela contribuição! Especialmente porque não temos Windows e fica difícil de recriar os cenários.
Valeu demais!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descrição
Para sistemas que não são baseados em UNIX (exemplo Windows) o comando
chmodnão existe, então quebra ao rodarmake install, é necessário adicionar uma validação para rodar o comando de forma condicional conforme o OSMudanças Propostas
make install, ver comentário com exemplo do funcionamento em Windows: adiciona validacao no Makefile para OS Windows #455 (comment)@em alguns comando afim de deixar o ouput (STDOUT) mais limpo, ver comentário com exemplo: adiciona validacao no Makefile para OS Windows #455 (comment)Checklist de Revisão
Comentários Adicionais (opcional)
Issue Relacionada
Closes #414