Change HTML injection to wait until "Files changed" tab is open#53
Merged
1 commit merged intobrentyates:masterfrom Jan 31, 2018
Merged
Change HTML injection to wait until "Files changed" tab is open#531 commit merged intobrentyates:masterfrom
1 commit merged intobrentyates:masterfrom
Conversation
|
I think this is a reasonable fix @stevennoto... I can release this at some point. Thanks for your contribution! |
ghost
merged commit 
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @Yatser, me again. I thought of another enhancement idea while tinkering with another extension.
I noticed that when you open a Pull Request page and it starts on the "Conversation" tab, and you tab over to "Files Changed" by clicking or hitting backtick, the prettypullrequests widgets are not present. I'm guessing at some point GitHub switched that navigation to use ajax/pjax, and as a result you need to reload the page to get the prettypullrequests UI to appear.
I fixed this by changing the HTML injection to effectively wait until the "Files Changed" tab is active. It seems to work in my tests. See what you think. Thanks again!