updated --config_key to --config-key for consistency#141
Merged
calvn merged 2 commits intobreser:masterfrom Mar 2, 2017
Merged
updated --config_key to --config-key for consistency#141calvn merged 2 commits intobreser:masterfrom
calvn merged 2 commits intobreser:masterfrom
Conversation
Contributor
|
I would love to guard against potential breakage of other people's deployment by allowing both flags for the short term (perhaps a release or two). We could deprecate the old flag, and remove it once people are aware of the changes. |
Author
|
Sure, I added |
|
Has this feature been released? |
Owner
|
Negative, you can view the documentation for the released versions by looking at the tag for that version. |
|
@breser Thanks, that helps! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--config-filecommand line option uses a-dash in the name and--config_keyoption currently uses an_underscore in the name. Updated to--config-keyso that both options consistently use a dash in the name.