Skip to content

updated --config_key to --config-key for consistency#141

Merged
calvn merged 2 commits intobreser:masterfrom
paperpunk:master
Mar 2, 2017
Merged

updated --config_key to --config-key for consistency#141
calvn merged 2 commits intobreser:masterfrom
paperpunk:master

Conversation

@paperpunk
Copy link
Copy Markdown

--config-file command line option uses a - dash in the name and --config_key option currently uses an _ underscore in the name. Updated to --config-key so that both options consistently use a dash in the name.

@calvn
Copy link
Copy Markdown
Contributor

calvn commented Mar 1, 2017

I would love to guard against potential breakage of other people's deployment by allowing both flags for the short term (perhaps a release or two). We could deprecate the old flag, and remove it once people are aware of the changes.

@paperpunk
Copy link
Copy Markdown
Author

Sure, I added --config_key for backwards compatibility

@huffleman51
Copy link
Copy Markdown

Has this feature been released?

@breser
Copy link
Copy Markdown
Owner

breser commented Aug 25, 2017

Negative, you can view the documentation for the released versions by looking at the tag for that version.

@huffleman51
Copy link
Copy Markdown

@breser Thanks, that helps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants