Skip to content
This repository was archived by the owner on Jan 2, 2021. It is now read-only.

Display hands raised icon on success and UTF-8 stdout#84

Merged
brettcannon merged 1 commit intobrettcannon:masterfrom
msabramo:flair2
Mar 16, 2015
Merged

Display hands raised icon on success and UTF-8 stdout#84
brettcannon merged 1 commit intobrettcannon:masterfrom
msabramo:flair2

Conversation

@msabramo
Copy link
Copy Markdown
Contributor

Slightly less flair. But still adds a bit of sexiness to Python 3 compatibility.

If this isn't good either, I promise I will stop 😄

screen shot 2015-03-16 at 7 54 02 am

@brettcannon
Copy link
Copy Markdown
Owner

Can you paste an example so I can see what it would look like?

@brettcannon
Copy link
Copy Markdown
Owner

Also, the tests are failing. And do you know if this will work on Windows? And is there a more party-themed character that's less alcohol-themed?

@msabramo
Copy link
Copy Markdown
Contributor Author

How about http://www.fileformat.info/info/unicode/char/1f64c/index.htm, assuming that fonts support that?

@msabramo
Copy link
Copy Markdown
Contributor Author

@msabramo
Copy link
Copy Markdown
Contributor Author

@msabramo
Copy link
Copy Markdown
Contributor Author

Here's what the "hands raised" glyph looks like:

screen shot 2015-03-14 at 9 45 58 am

@msabramo
Copy link
Copy Markdown
Contributor Author

On Windows, it doesn't display the icon, because the Windows terminal isn't UTF-8.

>>> sys.stdout.encoding
'cp437'

screen shot 2015-03-14 at 9 54 25 am

@msabramo msabramo changed the title Display beer icon on success and UTF-8 stdout Display hands raised icon on success and UTF-8 stdout Mar 14, 2015
@msabramo
Copy link
Copy Markdown
Contributor Author

Fixed failing Python 3 tests.

@msabramo
Copy link
Copy Markdown
Contributor Author

I think that addresses all of your questions/concerns. Let me know if you have others.

Comment thread caniusepython3/__main__.py Outdated
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change this to the \u escape so you don't have to bother with the bytes + decode step?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh but I thought I can't do u'\U...' because the project supports Python 3.2 and the u literal syntax was missing in Py3 until 3.3?

I'm probably overlooking something - give me an example and I can change.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see.

from __future__ import unicode_literals

@brettcannon
Copy link
Copy Markdown
Owner

Change it to http://www.fileformat.info/info/unicode/char/1f389/index.htm and I will accept the PR.

@msabramo
Copy link
Copy Markdown
Contributor Author

OK, done.

brettcannon added a commit that referenced this pull request Mar 16, 2015
Display the "party popper" emoji as a bit of flair when there are no blockers
@brettcannon brettcannon merged commit 28b7906 into brettcannon:master Mar 16, 2015
@brettcannon
Copy link
Copy Markdown
Owner

Thanks!

@msabramo
Copy link
Copy Markdown
Contributor Author

🎉 😄

@msabramo msabramo deleted the flair2 branch March 16, 2015 14:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants