Display hands raised icon on success and UTF-8 stdout#84
Display hands raised icon on success and UTF-8 stdout#84brettcannon merged 1 commit intobrettcannon:masterfrom
Conversation
|
Can you paste an example so I can see what it would look like? |
|
Also, the tests are failing. And do you know if this will work on Windows? And is there a more party-themed character that's less alcohol-themed? |
|
How about http://www.fileformat.info/info/unicode/char/1f64c/index.htm, assuming that fonts support that? |
|
Fixed failing Python 3 tests. |
|
I think that addresses all of your questions/concerns. Let me know if you have others. |
There was a problem hiding this comment.
Can you change this to the \u escape so you don't have to bother with the bytes + decode step?
There was a problem hiding this comment.
Oh but I thought I can't do u'\U...' because the project supports Python 3.2 and the u literal syntax was missing in Py3 until 3.3?
I'm probably overlooking something - give me an example and I can change.
There was a problem hiding this comment.
Oh, I see.
from __future__ import unicode_literals|
Change it to http://www.fileformat.info/info/unicode/char/1f389/index.htm and I will accept the PR. |
|
OK, done. |
Display the "party popper" emoji as a bit of flair when there are no blockers
|
Thanks! |
|
🎉 😄 |


Slightly less flair. But still adds a bit of sexiness to Python 3 compatibility.
If this isn't good either, I promise I will stop 😄