Skip to content

ssh-proxy: attach correct user for host ssh config#212

Merged
tmonty12 merged 1 commit intomainfrom
fix-lp-user
Nov 18, 2024
Merged

ssh-proxy: attach correct user for host ssh config#212
tmonty12 merged 1 commit intomainfrom
fix-lp-user

Conversation

@tmonty12
Copy link
Copy Markdown
Contributor

For Launchpad, the host user is nvidia. This wasn't being properly updated in the ssh config because it uses the ssh proxy which referenced the user variable defined by GetSSHUser not GetHostSSHUser.

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 13.25%. Comparing base (e28b4e5) to head (f4de46a).
Report is 42 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #212      +/-   ##
==========================================
+ Coverage   12.65%   13.25%   +0.60%     
==========================================
  Files          80      106      +26     
  Lines       11207    12604    +1397     
==========================================
+ Hits         1418     1671     +253     
- Misses       9590    10705    +1115     
- Partials      199      228      +29     
Flag Coverage Δ
Linux 13.25% <100.00%> (+0.60%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@tmonty12 tmonty12 merged commit 93888c4 into main Nov 18, 2024
@tmonty12 tmonty12 deleted the fix-lp-user branch November 18, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants