Skip to content

fix(login): add --no-interactive flag to suppress agentic prompts #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brycelelbach wants to merge 1 commit into from
Closed

fix(login): add --no-interactive flag to suppress agentic prompts #358

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions pkg/cmd/login/login.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ func NewCmdLogin(t *terminal.Terminal, loginStore LoginStore, auth Auth) *cobra.
var skipBrowser bool
var emailFlag string
var authProviderFlag string
var noInteractive bool

cmd := &cobra.Command{
Annotations: map[string]string{"configuration": ""},
Expand All @@ -69,6 +70,9 @@ func NewCmdLogin(t *terminal.Terminal, loginStore LoginStore, auth Auth) *cobra.
Long: "Log into brev",
Example: "brev login",
PostRunE: func(cmd *cobra.Command, args []string) error {
if noInteractive {
return nil
}
shouldWe := hello.ShouldWeRunOnboarding(loginStore)
if shouldWe {
user, err := loginStore.GetCurrentUser()
Expand All @@ -84,7 +88,7 @@ func NewCmdLogin(t *terminal.Terminal, loginStore LoginStore, auth Auth) *cobra.
},
Args: cmderrors.TransformToValidationError(cobra.NoArgs),
RunE: func(cmd *cobra.Command, args []string) error {
err := opts.RunLogin(t, loginToken, skipBrowser, emailFlag, authProviderFlag)
err := opts.RunLogin(t, loginToken, skipBrowser, emailFlag, authProviderFlag, noInteractive)
if err != nil {
// if err is ImportIDEConfigError, log err with sentry but continue
if _, ok := err.(*importideconfig.ImportIDEConfigError); !ok {
Expand All @@ -97,6 +101,9 @@ func NewCmdLogin(t *terminal.Terminal, loginStore LoginStore, auth Auth) *cobra.
}
return err //nolint:wrapcheck // we want to return the error from the login
}
if noInteractive {
return nil
}
// Offer Claude Code skill installation after successful login
homeDir, homeErr := opts.LoginStore.UserHomeDir()
if homeErr == nil {
Expand All @@ -109,6 +116,7 @@ func NewCmdLogin(t *terminal.Terminal, loginStore LoginStore, auth Auth) *cobra.
cmd.Flags().BoolVar(&skipBrowser, "skip-browser", false, "print url instead of auto opening browser")
cmd.Flags().StringVar(&emailFlag, "email", "", "email to use for authentication")
cmd.Flags().StringVar(&authProviderFlag, "auth", "", "authentication provider to use (nvidia or legacy, default is nvidia)")
cmd.Flags().BoolVar(&noInteractive, "no-interactive", false, "disable all interactive prompts (tutorial, analytics opt-in, agent-skill install); required for agentic/scripted use")
return cmd
}

Expand Down Expand Up @@ -157,13 +165,17 @@ func (o LoginOptions) getOrCreateOrg(username string) (*entity.Organization, err
return org, nil
}

func (o LoginOptions) RunLogin(t *terminal.Terminal, loginToken string, skipBrowser bool, emailFlag string, authProviderFlag string) error {
func (o LoginOptions) RunLogin(t *terminal.Terminal, loginToken string, skipBrowser bool, emailFlag string, authProviderFlag string, noInteractive bool) error {
tokens, _ := o.LoginStore.GetAuthTokens()

if authProviderFlag != "" && authProviderFlag != "nvidia" && authProviderFlag != "legacy" {
return breverrors.NewValidationError("auth provider must be nvidia or legacy")
}

if noInteractive && loginToken == "" {
return breverrors.NewValidationError("--no-interactive requires --token; browser-based login is interactive")
}

authenticator := auth.StandardLogin(authProviderFlag, emailFlag, tokens)

if emailFlag != "" && authenticator.GetCredentialProvider() != auth.CredentialProviderKAS {
Expand All @@ -187,7 +199,7 @@ func (o LoginOptions) RunLogin(t *terminal.Terminal, loginToken string, skipBrow
return breverrors.WrapAndTrace(err)
}

err = o.handleOnboarding(user, t)
err = o.handleOnboarding(user, t, noInteractive)
if err != nil {
return breverrors.WrapAndTrace(err)
}
Expand All @@ -200,7 +212,7 @@ func (o LoginOptions) RunLogin(t *terminal.Terminal, loginToken string, skipBrow
return nil
}

func (o LoginOptions) handleOnboarding(user *entity.User, _ *terminal.Terminal) error {
func (o LoginOptions) handleOnboarding(user *entity.User, _ *terminal.Terminal, noInteractive bool) error {
// figure out if we should onboard the user
currentOnboardingStatus, err := user.GetOnboardingData()
if err != nil {
Expand Down Expand Up @@ -233,7 +245,7 @@ func (o LoginOptions) handleOnboarding(user *entity.User, _ *terminal.Terminal)
}

_, analyticsAsked := analytics.IsAnalyticsEnabled()
if !analyticsAsked && analytics.IsAnalyticsFeatureEnabled() {
if !analyticsAsked && analytics.IsAnalyticsFeatureEnabled() && !noInteractive {
Copy link

Copilot AI Apr 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The noInteractive guard is last in the && chain, so when !analyticsAsked is true this still calls analytics.IsAnalyticsFeatureEnabled() even in --no-interactive mode. That function performs a PostHog feature-flag network call, which defeats the goal of fast/non-agentic-safe execution. Reorder the condition (or early-return) so noInteractive short-circuits before any network call.

Suggested change
if !analyticsAsked && analytics.IsAnalyticsFeatureEnabled() && !noInteractive {
if !analyticsAsked && !noInteractive && analytics.IsAnalyticsFeatureEnabled() {

Copilot uses AI. Check for mistakes.
choice := terminal.PromptSelectInput(terminal.PromptSelectContent{
Label: "Help us improve Brev by sharing usage data?",
ErrorMsg: "Error: must choose an option",
Expand Down
Loading