Conversation
- Update Match model to include optional `tournamentId` field. - Update `MatchForm` to include `tournament_id` and `group_id` hidden fields. - Restrict player selection to tournament participants when recording a match from a tournament context. - Pre-fill tournament information in the Match Recording UI. - Enrich dashboard match history with tournament names and display a tournament badge. - Add styling for the tournament badge. - Add comprehensive unit tests for the integration. Co-authored-by: brewmarsh <12343321+brewmarsh@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Agent Scorecard ReportTarget Agent Profile: Standard Agent Readiness checks (ACL & Type Safety) ✅ Status: PASSED - This codebase is Agent-Ready. 🎯 Top Refactoring Targets (Agent Cognitive Load (ACL))ACL = Complexity + (Lines of Code / 20). Target: ACL <= 10.
🛡️ Type Safety IndexTarget: >90% of functions must have explicit type signatures.
🤖 Agent Prompts for RemediationFile:
|
| File | Score | Issues |
|---|---|---|
| pickaladder/user/utils.py | 85 ✅ | 3 Yellow ACL functions (-15) |
| pickaladder/match/forms.py | 80 ✅ | Type Safety Index 0% < 90% (-20) |
| pickaladder/match/routes.py | 60 ❌ | 1 Red ACL functions (-15), 5 Yellow ACL functions (-25) |
| tests/test_tournament_match_integration.py | 100 ✅ |
Generated by Agent-Scorecard
- Update Match model to include optional `tournamentId` field. - Update `MatchForm` to include `tournament_id` and `group_id` hidden fields for data persistence. - Restrict player selection to tournament participants when recording a match from a tournament context. - Pre-fill tournament information in the Match Recording UI. - Enrich dashboard match history with tournament names and display a tournament badge. - Add styling for the tournament badge. - Fix linting, formatting, and type safety issues (Ruff/Mypy). - Add comprehensive unit tests for the integration. Co-authored-by: brewmarsh <12343321+brewmarsh@users.noreply.github.com>
Linked matches to tournaments by adding a
tournamentIdfield to the matches collection. Updated the Match Recording UI to automatically pre-fill tournament context and restrict player selection to tournament participants when accessed from a tournament page. Modified the User Dashboard to display a '🏆 [Tournament Name]' badge next to the score for matches associated with a tournament. Added hidden fields to the match form to ensure reliable data persistence.Fixes #660
PR created automatically by Jules for task 9565725900535790803 started by @brewmarsh