connection string parsing issue

[machunter]

there seem to be a problem with using the url.parse method if the password contains special url characters. the work around is to use an option object. but i ended spending some time before figuring this out.

my password had an % in it, i am suspecting that it was the culprit.

[booo]

This is a known problem: #34

Maybe we should add this information to the wiki?

[booo]

Seems like the problem is fixed: nodejs/node-v0.x-archive#1163 (comment)

[brianc]

@machunter Could you include a bit of information:

What version of node-postgres are you using? What version of node are you using? Could you include an example of a password which improperly parses?

Bonus points: Could you submit a snip of code in the bug? Or even more turbo bonus points how about a pull request with a failing test?

[dimitar-ivanov]

Had the same issue as @machunter . The problem comes from the fact that Nodejs url's module is used for parsing Connection strings! Connection strings may look the same as URL strings, but they are not!

Just have a look at how utils.parseConnectionString is implemented. Quick example to illustrate my point.
A valid Connections string is the following:
'postgres://administrator#sfgq1:my-very-secret-password@localhost:5432/testdb

Because Url.parse method has been used the # symbol breaks the whole connection string into wrong pieces i.e as result connection cannot be established.

Quick work around will be to support also config obj not just connection strings.

[brianc]

The connection string parsing has been refactored and concentrated into this file:

https://github.com/brianc/node-postgres/blob/master/lib/connection-parameters.js#L14

I'll happily and quickly fix any specific parsing issues you encounter. Just open an issue with the connection string and the expected parse output.