Date type parser #163
Merged
Date type parser #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: add integration test
TODO: Fix the javascript binary parser too.
We don't parse date types in the javascript binary parser. Keep this in mind if you plan to use the binary javascript parser.
|
awesome :) |
|
i owe you a beer =) |
Owner
|
@booo you are awesome. If you're interested you can email me at brian.m.carlson@gmail.com and we could discuss you having commit access & npm publish rights for node-postgres. If you'd rather work on your branch and manage through pull requests I'm 100% fine with that as well. Honestly it will take more back & forth communication to share the main repo, but you've more than "earned your stripes" or whatever the hell that means. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like all tests are fine. Hope this is something you can work with.
Best Regards
Philipp