Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

tls socket missing error listener #586

Merged
merged 1 commit into from May 8, 2014

Conversation

2 participants
Contributor

solomon23 commented May 7, 2014

This fixes #585

I wasn't able to add a unit test since it's making use of tls and i would need to stub that out. I usually use proxyquire or sinon to create mock objects for unit testing.

Owner

brianc commented May 8, 2014

Thanks. :) 👍

@brianc brianc added a commit that referenced this pull request May 8, 2014

@brianc brianc Merge pull request #586 from solomon23/tls-error
tls socket missing error listener
728b7c9

@brianc brianc merged commit 728b7c9 into brianc:master May 8, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment