update asa #77
update asa #77
Conversation
bin/asa
Outdated
|
|
||
| use strict; | ||
| use warnings; | ||
| use List::Util qw/ any /; |
There was a problem hiding this comment.
The question is if loading a module saves a significant amount of time over using a slightly inefficient grep. Can you benchmark both ways and see which one is faster?
There was a problem hiding this comment.
Loading the module caused the 5.8 travis build to fail which I note is a requirement so I reverted back to the grep block form in the second commit. So ultimately the only thing that changed was I turned on warnings and changed the grep from expression to block form.
There was a problem hiding this comment.
That's odd because List::Util was core in 5.7.3.
For the warnings, I have the same comment as in #78. I'm not sure about shipping developer settings to end users.
There was a problem hiding this comment.
'any' is only listed as a suggested addition in 5.8 docs.
Let me know if you make a decision, I'm happy to help in any way I can.
|
So far we haven't added warnings to the scripts, so I'm deferring this. |
briandfoy
added
Status: released
2 participants
enable warnings and use any instead of grep in boolean context