New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use three-arg form of open() #13

Merged
merged 1 commit into from Oct 10, 2017

Conversation

Projects
None yet
3 participants
@paultcochrane
Contributor

paultcochrane commented Oct 8, 2017

I found a couple of instances of the older two-arg form of open() being used and have updated the code to use the three-arg form here. The tests still pass and Travis seems happy with the change as well.

This PR is submitted in the hope that it is useful. If you have any questions or comments concerning it, please let me know and I can update and resubmit as necessary.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Oct 8, 2017

Coverage Status

Coverage remained the same at 66.94% when pulling 6522bc2 on paultcochrane:pr/use-three-arg-open into 67cf94a on briandfoy:master.

coveralls commented Oct 8, 2017

Coverage Status

Coverage remained the same at 66.94% when pulling 6522bc2 on paultcochrane:pr/use-three-arg-open into 67cf94a on briandfoy:master.

@briandfoy briandfoy merged commit afc2448 into briandfoy:master Oct 10, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@paultcochrane paultcochrane deleted the paultcochrane:pr/use-three-arg-open branch Oct 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment