Skip to content

Restrict loop variable scope to loop #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2017
Merged

Restrict loop variable scope to loop #15

merged 1 commit into from
Oct 10, 2017

Conversation

@paultcochrane
Copy link
Contributor

@paultcochrane paultcochrane commented Oct 8, 2017

Perlcritic noticed that the loop variable changed here wasn't scoped to
the loop it refers to. This change fixes the variable's scope.

@paultcochrane
Restrict loop variable scope to loop
f8184fc 
Perlcritic noticed that the loop variable changed here wasn't scoped to
the loop it refers to.  This change fixes the variable's scope.
@coveralls
Copy link

coveralls commented Oct 8, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 66.94% when pulling f8184fc on paultcochrane:pr/make-loop-var-lexical into 67cf94a on briandfoy:master.

@briandfoy briandfoy merged commit 1c002ca into briandfoy:master Oct 10, 2017
@paultcochrane paultcochrane deleted the pr/make-loop-var-lexical branch October 21, 2017 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@paultcochrane @coveralls @briandfoy