New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict loop variable scope to loop #15

Merged
merged 1 commit into from Oct 10, 2017

Conversation

Projects
None yet
3 participants
@paultcochrane
Contributor

paultcochrane commented Oct 8, 2017

Perlcritic noticed that the loop variable changed here wasn't scoped to
the loop it refers to. This change fixes the variable's scope.

Restrict loop variable scope to loop
Perlcritic noticed that the loop variable changed here wasn't scoped to
the loop it refers to.  This change fixes the variable's scope.
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Oct 8, 2017

Coverage Status

Coverage remained the same at 66.94% when pulling f8184fc on paultcochrane:pr/make-loop-var-lexical into 67cf94a on briandfoy:master.

coveralls commented Oct 8, 2017

Coverage Status

Coverage remained the same at 66.94% when pulling f8184fc on paultcochrane:pr/make-loop-var-lexical into 67cf94a on briandfoy:master.

@briandfoy briandfoy merged commit 1c002ca into briandfoy:master Oct 10, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@paultcochrane paultcochrane deleted the paultcochrane:pr/make-loop-var-lexical branch Oct 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment