Skip to content

Fix deprecation warning on rubocop plugins/require change#114

Merged
briandunn merged 3 commits intobriandunn:masterfrom
mjankowski:rubocop-deprecation-plugins
Feb 4, 2026
Merged

Fix deprecation warning on rubocop plugins/require change#114
briandunn merged 3 commits intobriandunn:masterfrom
mjankowski:rubocop-deprecation-plugins

Conversation

@mjankowski
Copy link
Collaborator

@mjankowski mjankowski force-pushed the rubocop-deprecation-plugins branch from 3937948 to 7296402 Compare January 27, 2026 15:26
@mjankowski mjankowski force-pushed the rubocop-deprecation-plugins branch from 7296402 to c94eb2e Compare January 28, 2026 18:58
@mjankowski
Copy link
Collaborator Author

This also:

  • Adds minimum rubocop version, to avoid CI/local disconnects
  • Regen appraisal files after recent changes (including that rubocop change)

@briandunn briandunn merged commit 6015bb6 into briandunn:master Feb 4, 2026
38 checks passed
@mjankowski mjankowski deleted the rubocop-deprecation-plugins branch February 4, 2026 15:29
@mjankowski
Copy link
Collaborator Author

Followup on this, in advance of what I assume might be an upcoming 2.4.0 release (to get ruby 4.0 support into tagged version?)... thoughts on any/all of the following as well:

  • Ruby 3.1 is EOL and 3.2 will be in a few months, could drop 3.1 from CI matrix, and/or gemspec
  • The rspec versions being excluded from CI matrix (for lack of ruby 4.0 support) are also pretty old ... could possibly bump the minimum version there at some point as it becomes less likely that anyone running a modern/supported ruby has also not updated rspec
  • I'm not sure on full history here, but I noticed while doing this PR that rubocop-rspec is a) included in the gemfile, but b) commented out in rubocop config. There are ~90 RSpec/* offenses, with only ~30 autocorrectable. Might make sense to either remove that from gemfile and config, or fix them?

Let me know any thoughts on that stuff and if PRs would be welcome - otherwise will sit tight on tagged release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants