Diagnose cross-modal retrieval gaps#28
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 95529a3f97
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| generic_count = sum(1 for query in query_values if query in GENERIC_MEDIA_QUERIES) | ||
| return generic_count > 0 and generic_count >= max(1, len(query_values) // 2) |
There was a problem hiding this comment.
Require a true majority before tagging generic-query artifact
Use a ceiling threshold here; with len(query_values) // 2, odd-sized categories are misclassified. For example, with 3 media queries and only 1 placeholder, generic_count >= 1 becomes true, so the tool emits generic_query_artifact and can inflate priority_score/follow-up actions even when generic prompts are not the majority. This skews the ranked diagnosis for small categories and should use a strict majority check (e.g., >= ceil(n/2) or > n/2).
Useful? React with 👍 / 👎.
Summary
Research grounding
Tests