REC-33: Add alpha/beta testing program#37
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 56ab0df612
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| name="RECALLFORGE_ENABLE_RAW_VIDEO_QUERY_EMBEDDING", | ||
| default="0", | ||
| description="Enable raw video query embedding instead of safer caption/transcript-first retrieval.", |
There was a problem hiding this comment.
RECALLFORGE_ENABLE_RAW_VIDEO_QUERY_EMBEDDING is registered with a hardcoded default of "0", but the search runtime uses a backend-dependent default (True on non-MLX backends, False on MLX). When the env var is unset on torch/CUDA, recallforge flags and crash reports will incorrectly state the flag is off, which can mislead alpha/beta diagnostics and retrieval-quality investigations.
Useful? React with 👍 / 👎.
| if value in {"1", "true", "yes", "on"}: | ||
| return True |
There was a problem hiding this comment.
enabled_from() treats "true", "yes", and "on" as enabled for all boolean-like flags, including RECALLFORGE_TRACE, but the actual trace toggles in server/storage are enabled only when the env value is exactly "1". This can produce false-positive "enabled" output in recallforge flags/crash reports during debugging sessions.
Useful? React with 👍 / 👎.
1 participant
Summary
recallforge flagsand local-only opt-inrecallforge crash-reportdiagnostics with testsValidation
python3 -m compileall -q src testspython3 -m pytest -q(563 passed, 18 skipped, 18 subtests passed)bash tests/uat/test_mcp_server.sh(PASS 63 / FAIL 0).venv/bin/python -m pip wheel . -w /tmp/recallforge-wheel-rec33PYTHONPATH=/tmp/recallforge-twine .venv/bin/python -m twine check /tmp/recallforge-wheel-rec33/recallforge-0.3.0-py3-none-any.whlpython3 -m recallforge.cli flags --jsonpython3 -m recallforge.cli crash-report --message smoke.github/ISSUE_TEMPLATEand.github/DISCUSSION_TEMPLATELinear: REC-33