Rename *ring* internals to avoid conflicts with OpenSSL.#280
Rename *ring* internals to avoid conflicts with OpenSSL.#280briansmith wants to merge 12 commits intorustfmtfrom
Conversation
|
Just to clarify: This is a WIP. It isn't done yet. I'll keep updating the PR as I make progress. |
briansmith
force-pushed
the
rename_gfp
branch
6 times, most recently
from
feabbc0 to
13a87c6
Compare
Also, make many Curve25519 extern functions static, and remove some dead code.
They were previously functions so that they worked when *ring* was built as a DLL on Windows, but that's not a supported configuration, so thats unnecessary.
|
Landed in master as: fcbf905 Use the GFp_ prefix for nistz384 externs. |
|
Can this be closed? |
|
I'm going to leave this open because (a) I didn't verify it is correct on every target, especially no-asm, ARM32, AAarch64, and (b) I want to add something to the build/test automation to ensure there are no regressions in this. |
The remaining work is now tracked in #297. |
2 participants
This series of commits will rename every single extern C symbol in ring so that each one has a different name from any OpenSSL function. This should allow ring and rust-openssl to be linked together into the same program.