Skip to content

Conversation

@twexler
Copy link
Contributor

@twexler twexler commented Jun 30, 2021

This depends on a yet-to-be-released v0.3.2 of brianstrauch/spotify. Once that's released, this can be merged!

@twexler
Copy link
Contributor Author

twexler commented Jun 30, 2021

Actually, regarding the versioning...should it be v0.4.0, perhaps?

twexler and others added 2 commits July 2, 2021 17:23
Co-authored-by: Brian Strauch <bstrauch24@gmail.com>
Copy link
Owner

@brianstrauch brianstrauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Make a few quick fixes and you're good to merge. Some of my comments mention writing tests; feel free to write some, but I can write those if you don't have time 😄

Co-authored-by: Brian Strauch <bstrauch24@gmail.com>
Copy link
Owner

@brianstrauch brianstrauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge when everything's ready to go!

@twexler
Copy link
Contributor Author

twexler commented Jul 3, 2021

Feel free to merge when everything's ready to go!

Doesn't look like I have merge permissions, but thanks for the confidence!

@brianstrauch
Copy link
Owner

Doesn't look like I have merge permissions, but thanks for the confidence!

Oh right, merging now!

@brianstrauch brianstrauch merged commit 36658c0 into brianstrauch:master Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants