Test enhancement #10
Test enhancement #10
Conversation
|
|
tests/NativeCalculatorTest.php
Outdated
| @@ -0,0 +1,102 @@ | |||
| <?php | |||
|
|
|||
| namespace Brick\Math\Tests; | |||
There was a problem hiding this comment.
Should be Brick\Math\Tests\Internal\Calculator and file moved to the appropriate directory
| $this->assertBigIntegerEquals($value, unserialize(serialize($number))); | ||
| } | ||
|
|
||
| public function testJsonSerialize() |
There was a problem hiding this comment.
Please move this test below testDirectCallToUnserialize!
|
Hi @BenMorel, thank you for your reply. |
| @@ -0,0 +1,103 @@ | |||
| <?php | |||
There was a problem hiding this comment.
File name should be tests/Internal/Calculator/NativeCalculatorTest.php
|
I know, hence the "note to self" for posterity. Please just move the NativeCalculatorTest as requested and it will be good to merge! |
|
I'm sorry for that delay because I'm busy in the past of two days. |
| * | ||
| * @param string $a The input numerator. | ||
| * @param string $b The input denominator. | ||
| * @param string $expectedValue The expected denominator. |
There was a problem hiding this comment.
It's not numerator & denominator here. You can just remove the descriptions.
| * | ||
| * @param string $a The input numerator. | ||
| * @param string $b The input denominator. | ||
| * @param string $expectedValue The expected denominator. |
| * | ||
| * @param string $a The input numerator. | ||
| * @param string $b The input denominator. | ||
| * @param string $expectedValue The expected denominator. |
|
All good, thanks! |
2 participants
Changed log
suggestkey incomposer.jsonto suggest the extensions.