Skip to content

Add proper T9 input support#364

Merged
brickbots merged 12 commits intobrickbots:mainfrom
RichardHum:release
Mar 1, 2026
Merged

Add proper T9 input support#364
brickbots merged 12 commits intobrickbots:mainfrom
RichardHum:release

Conversation

@RichardHum
Copy link

This PR adds in proper T9 search, as compared to the current multi-tap approach. I've tested it and I haven't encountered any issues.

@brickbots brickbots changed the base branch from release to main December 2, 2025 18:24
@brickbots
Copy link
Owner

Hello @RichardHum ! Thanks for this cool addition 👍

I've changed the merge base to main as this is our regular development branch where this will be merged and tested prior being added to a specific release. Sorry this has introduced a merge conflict, but it looks like it should be easy to resolve.

Please let me know me if you have any difficulty resolving the conflict, I'm happy to help!

@RichardHum RichardHum marked this pull request as draft December 3, 2025 12:54
@RichardHum
Copy link
Author

Ah I should have read the documentation more closely. Since the WDS is so large, I'm working on some optimizations before submitting this for final review.

Add cached T9 digit mapping for catalog searches
@RichardHum RichardHum marked this pull request as ready for review December 3, 2025 16:33
@RichardHum
Copy link
Author

I added caching on the T9 letter->number mapping so it only needs to run once during the search.

Should be ready to merge now.

@brickbots
Copy link
Owner

Hi @RichardHum Sorry for the delay on this PR. I'd like to get this merged along with a host of other great QOL changes for a release in the next week or so. Are you able to resolve the minor conflict in textentry.py? Looking at its I don't think it's actually a conflict but just an artifact of the automerge

@RichardHum
Copy link
Author

Should be resolved now

@brickbots brickbots merged commit 976d995 into brickbots:main Mar 1, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants