Conversation
|
Thank you @casazza for getting this PR up and for the work to add the Harris catalog! I've updated the base to brickbots:main from the default brickbots:release as main is where we stage new stuff to test 👍 Before I any specific comments on the PR, please take a look through the 'Files Changed' up at the top and make sure these are each items you intended to change. Changing the merge base will adjust the changeset for the PR. Once you've take a look, let me know here or via discord and I'll go through and give some specific notes! Cheers! |
|
BB My newness is showing. I understand git and branching enough to get myself in trouble. Clearly my first pull request ever... These were unintended changes. I'm not 100% sure the best path forward. astro_data/lynga folder -- inadvertant I can remove this it is the next catalog python/PiFinder/fonts/RobotoMono-Bold.ttf -- no idea how this changed python/PiFinder/ui/marking_menus.py -- Change I needed to make to get this running locally (newer python requirement) You tell me the best way forward. |
|
can this be closed because it's replaced by #384 ? |
|
Yes. It can be closed. 834 is a full replacement. |
Adding the Harris Globular Cluster catalog
astro_data/harris (new folder with files)
python/PiFinder/catalog_imports/harris_loader.py (new)
python/PiFinder/catalog_imports/main.py (my loader added)
python/ui/menu_structure.py (added Harris to Catalogs and Filters)
docs/source/catalogs.rst (Harris catalog added)