Skip to content

Harris catalog loader#383

Closed
casazza wants to merge 8 commits intobrickbots:mainfrom
casazza:harris-catalog-loader
Closed

Harris catalog loader#383
casazza wants to merge 8 commits intobrickbots:mainfrom
casazza:harris-catalog-loader

Conversation

@casazza
Copy link

@casazza casazza commented Feb 17, 2026

Adding the Harris Globular Cluster catalog
astro_data/harris (new folder with files)
python/PiFinder/catalog_imports/harris_loader.py (new)
python/PiFinder/catalog_imports/main.py (my loader added)
python/ui/menu_structure.py (added Harris to Catalogs and Filters)
docs/source/catalogs.rst (Harris catalog added)

@brickbots brickbots changed the base branch from release to main February 17, 2026 01:00
@brickbots
Copy link
Owner

Thank you @casazza for getting this PR up and for the work to add the Harris catalog!

I've updated the base to brickbots:main from the default brickbots:release as main is where we stage new stuff to test 👍

Before I any specific comments on the PR, please take a look through the 'Files Changed' up at the top and make sure these are each items you intended to change. Changing the merge base will adjust the changeset for the PR. Once you've take a look, let me know here or via discord and I'll go through and give some specific notes!

Cheers!

@casazza
Copy link
Author

casazza commented Feb 17, 2026

BB

My newness is showing. I understand git and branching enough to get myself in trouble. Clearly my first pull request ever...

These were unintended changes. I'm not 100% sure the best path forward.

astro_data/lynga folder -- inadvertant I can remove this it is the next catalog
astro_data/pifinder_objects.db -- primary database not needed
astro_data/pifinder_objects_backup.db -- database backup not needed
.gitignore -- added things I did not want in my repo

python/PiFinder/fonts/RobotoMono-Bold.ttf -- no idea how this changed
python/PiFinder/fonts/RobotoMono-Regular.ttf -- no idea how this changed
python/PiFinder/fonts/RobotoMonoNerdFontMono-Bold.ttf -- no idea how this changed
python/PiFinder/fonts/RobotoMonoNerdFontMono-Regular.ttf -- no idea how this changed
python/requirements.txt -- no idea how this changed

python/PiFinder/ui/marking_menus.py -- Change I needed to make to get this running locally (newer python requirement)

You tell me the best way forward.

@mrosseel
Copy link
Collaborator

can this be closed because it's replaced by #384 ?

@casazza
Copy link
Author

casazza commented Feb 21, 2026

Yes. It can be closed. 834 is a full replacement.

@casazza casazza closed this Feb 21, 2026
@casazza casazza deleted the harris-catalog-loader branch March 3, 2026 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants