test(web): fix remote-nav sequences for current menu layout#492
Merged
Conversation
The Selenium web tests drive PiFinder's remote keypad with fixed key sequences and assert the resulting screen. Two menu changes on main shifted item indices, deterministically breaking 16 navigation tests: - Objects submenu gained an "Obs Lists" item at index 3, shifting Custom (3->4), Name Search (4->5) and Set Filters (5->6). - Start submenu reordered so GPS Status is now index 3 (was 2). Update the affected key sequences plus their docstrings/comments: - test_web_remote_filter.py (11): Objects->Set Filters hop RDDDDD->RDDDDDD - test_web_remote_objects.py (2): Custom RDDDR->RDDDDR; Set Filters ->RDDDDDDR - test_web_remote.py (2): Name Search RDDDDR->RDDDDDR - test_web_locations.py (1): Start->GPS Status RDD->RDDD Verified: all 16 pass against a live headless instance. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Selenium web tests drive PiFinder's remote keypad with fixed key sequences and assert the resulting screen (
ui_type/title/current_item). Two menu changes onmainshifted item indices, deterministically breaking 16 navigation tests (not flakiness — confirmed by re-running in isolation):Focus, Align, Align (Day), GPS Status.The real menu order was confirmed by driving a live headless instance and reading
/api/current-selectionafter each keypress.Changes
test_web_remote_filter.pyRDDDDD→RDDDDDD(+ docstring/comments)test_web_remote_objects.pyRDDDR→RDDDDR; Set FiltersRDDDDDR→RDDDDDDR(+ docstring)test_web_remote.pyRDDDDR→RDDDDDR(test_remote_entry,test_remote_entry_digits)test_web_locations.pytest_locations_add_remote: Start→GPS StatusRDD→RDDDOnly key sequences and their docstrings/comments changed — no assertions or test logic altered.
Validation
Run against a live headless PiFinder instance:
Out of scope
The two other failures in the current
-m webrun —test_locations_testloc_presentandtest_locations_add_test_locations— are not navigation. Both pass in isolation; they're order/state-dependent (a definition-order data dependency and a Materialize form-CRUD first-add timing issue). Left unchanged here.🤖 Generated with Claude Code