feat: accept both angular and @brickhouse-tech/angular-lts as peer deps#42
Merged
feat: accept both angular and @brickhouse-tech/angular-lts as peer deps#42
Conversation
- Add angular >=1.8.0 as optional peer dep (no breakage for existing users) - Keep @brickhouse-tech/angular-lts as optional peer dep (clean audit path) - Both are optional — consumers must install at least one - Fix 2 audit vulnerabilities in devDependencies (ajv, flatted) - Add security callout in README directing users to LTS fork - npm audit reports 0 vulnerabilities with either peer dep choice - Stock angular users see audit warnings from angular itself, not from us
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
angular >= 1.8.0as an optional peer dep alongside@brickhouse-tech/angular-lts. Both are optional — consumers install whichever they prefer.Why
angular@1.8.3get 9 audit warnings fromangularitself — not from us@brickhouse-tech/angular-ltsfor a clean auditChanges
package.json: addangular >= 1.8.0as optional peer dep withpeerDependenciesMetapackage-lock.json: fix 2 audit vulnerabilities in devDeps (ajv, flatted)README.md: add security section recommending LTS forkVerified
npm audit= 0 vulnerabilities (full + prod-only)angular@1.8.3: no peer dep warnings, audit issues come fromangularpackage only@brickhouse-tech/angular-lts: zero audit issues